Repository navigation
Make verifyUserRelations() more robust - #3938
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
@slnode test please |
The fix introduced in previous commit was relying on the default merge algorighm applied when a child model inherits relation config from the parent. This commit changes the check to use a more reliable approach based on the relation metadata configured by the child model.
|
Thank you @mcitdev for the pull request. The code changes looks good 👍 The commit history was a bit of a mess, I cleaned it up for you and rebased your patch on top of the latest Because you send the PR from your
In the future, please create a new feature branch for each pull request. I recommend the following guide for step-by-step instructions showing the recommended contribution workflow: https://www.nearform.com/blog/first-time-with-open-source/ |
|
Landed 🎉 Thank you for the contribution ❤️ |
|
I confess that I learned lot about git stuff from you, Thanks @bajtos |
Description
Refactoring the verifyUserRelations function to :
See also #3934